Skip to content

Add textFieldContentPadding modifier for compact text fields#470

Merged
marcprux merged 3 commits into
skiptools:mainfrom
MollisWare:feature/textfield-content-padding
Jul 1, 2026
Merged

Add textFieldContentPadding modifier for compact text fields#470
marcprux merged 3 commits into
skiptools:mainfrom
MollisWare:feature/textfield-content-padding

Conversation

@IT-Guy007

Copy link
Copy Markdown
Contributor

Adds a textFieldContentPadding(_:) View modifier (plus a bridged variant) that overrides the OutlinedTextField content padding. When set, TextField renders via BasicTextField + OutlinedTextFieldDefaults.DecorationBox so the padding — and therefore the field height — is honored; the default OutlinedTextField rendering path is unchanged.

Thank you for contributing to the Skip project! Please review the contribution guide at https://skip.dev/docs/contributing/ for advice and guidance on making high-quality PRs.

Use this space to describe your change and add any labels (bug, enhancement, documentation, etc.) to help categorize your contribution.

Skip Pull Request Checklist:

  • REQUIRED: I have signed the Contributor Agreement
  • REQUIRED: I have tested my change locally with swift test
  • OPTIONAL: I have tested my change on an iOS simulator or device
  • OPTIONAL: I have tested my change on an Android emulator or device
  • REQUIRED: I have checked whether this change requires a corresponding update in the Skip Fuse UI repository (link related PR if applicable)
  • OPTIONAL: I have added an example of any UI changes to the Showcase sample app

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes.

skip-fuse-ai will also get a pr

Adds a textFieldContentPadding(_:) View modifier (plus a bridged variant)
that overrides the OutlinedTextField content padding. When set, TextField
renders via BasicTextField + OutlinedTextFieldDefaults.DecorationBox so the
padding — and therefore the field height — is honored; the default
OutlinedTextField rendering path is unchanged.
@cla-bot cla-bot Bot added the cla-signed label Jun 22, 2026
@IT-Guy007

Copy link
Copy Markdown
Contributor Author

@marcprux ready for review

@marcprux

Copy link
Copy Markdown
Member

Do you happen to have a screenshot of how this looks?

@IT-Guy007

Copy link
Copy Markdown
Contributor Author

I do not, I tested it locally with skip-fuse-ui the default padding was gone

@IT-Guy007

Copy link
Copy Markdown
Contributor Author

@marcprux is a screenshot blocking the acceptance of this improvement?
Currently we are using a fork as workaround, would be great to reference the official package again.

@marcprux

Copy link
Copy Markdown
Member

No, sorry, I just hadn't gotten back to it. I'll merge it now and cut a new release. Thanks for the contribution!

@marcprux marcprux left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where's the actual View.textFieldContentPadding() implementation? I see the var _textFieldContentPadding: EdgeInsets? modifier, but no way to actually set this value (either directly in transpiled code, or via the bridged invocation in https://github.com/skiptools/skip-fuse-ui/pull/126/changes).

@IT-Guy007

IT-Guy007 commented Jun 30, 2026

Copy link
Copy Markdown
Contributor Author

Where's the actual View.textFieldContentPadding() implementation? I see the var _textFieldContentPadding: EdgeInsets? modifier, but no way to actually set this value (either directly in transpiled code, or via the bridged invocation in https://github.com/skiptools/skip-fuse-ui/pull/126/changes).

Maybe I misunderstand what your question is, but the PR 126 has the implementation to use the modifier implemented in this repo.

@IT-Guy007 IT-Guy007 requested a review from marcprux June 30, 2026 20:41
@marcprux

Copy link
Copy Markdown
Member

What I mean is, there should also be a way to activate this modifier for transpiled Skip Lite projects, which should (generally) have feature parity with the native Skip Fuse APIs.

@IT-Guy007

Copy link
Copy Markdown
Contributor Author

Added SkipLite implementation

@marcprux marcprux merged commit f744eff into skiptools:main Jul 1, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants